Re-word Chemistry warning texts #651
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #651 +/- ##
==========================================
+ Coverage 34.16% 34.17% +0.01%
==========================================
Files 520 520
Lines 23245 23244 -1
Branches 2849 2850 +1
==========================================
+ Hits 7941 7944 +3
+ Misses 14503 14499 -4
Partials 801 801 ☔ View full report in Codecov by Sentry. |
jsharkey13
reviewed
Oct 21, 2024
| // FIXME: This currently clashes with determining whether the submitted answer was the wrong type | ||
| // Inequality should be changed to not allow Nuclear syntax in Chemistry questions and vice versa | ||
| feedback = new Content("Your answer contains invalid syntax!"); | ||
| feedback = new Content("Your answer is not chemically valid!"); |
There was a problem hiding this comment.
I've always thought this warning was a bit "in your face" and certain. It's now even more certain, and yet I think that it's just as likely we don't support whatever they are trying to do. For numeric questions we use a softer tone: "Your answer is not in a format we recognise".
We could do something similar here: "Your answer is not in a format we recognise; it might not be chemically valid."?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to Andrea's feedback:
& add exclamation marks to the end of those that do not already have them, for unity e.g. “Your equation is unbalanced.”